Character progression missing heroic on boss

Carteron	wysłany: 12 lat temu I have automated tests to validate the response payloads for the APIs. It's been very helpful for me to notice when API updates have been made or data fixes have been made. I ran my said tests tonight and found that some of the raid bosses no longer have the heroic info shown in the payload. Just wanted to raise this issue for attention. The test that caught the issue: https://gist.github.com/4631225 Test failure is: Object does not contain heroicKills attribute Failed asserting that object of class "stdClass" has attribute "heroicKills".
Peratryn	wysłany: 12 lat temu Which boss is it? As part of an update today (that added timestamps to progression counters) we also removed the heroicKills attribute from bosses that don't have a heroic mode. This should match the main profile page as well now. Clearly we might have screwed up a boss that should have a heroic counter.
Peratryn	wysłany: 12 lat temu Cool, I will track down all of the bosses that are missing today.
Peratryn	wysłany: 12 lat temu also, could you please tell us the significance of the normal and heroic values in the dungeon's portion of the data? `"raids": [ { "name": "Molten Core", "normal": 2, "heroic": 0, "id": 2717, "bosses": [ { "id": 11502, "name": "Ragnaros", "normalKills": 26, "normalTimestamp": 1336222744000 } ] }]` I understand normalKills under the boss, but under the dungeon name is where I'm asking. It's a status value of 0 1 or 2 that corresponds with NONE, INPROGRESS, COMPLETED. It's what front end uses for the yellow and green boxes on the site.
Peratryn	wysłany: 12 lat temu 01/25/2013 09:50 AMPosted by Eethan Is the timestamp tracking the last time the boss was killed? or the first? It should be the latest, not the first. It's the last time that counter was updated. If you see issues in the data let us know.
Peratryn	wysłany: 12 lat temu The docs are pretty old, I just haven't had time to really update them. I plan on it soon :)
Peratryn	wysłany: 12 lat temu Not sure if this has anything to do with this issue... I noticed my armory page is missing some boss kills I had. My Cata progression shows me as missing heroic Toxitron, Valiona, and Elemental Monstrosity kills, however I have killed all these on heroic. I have the achieve. Also noticed going back further I have no credit for Icehowl and Mimiron. Looks kinda funny having killed Yogg 45 times, but 0 Mimiron kills :P The fixes for Garalon caused other issues that I'm planning to fix at some point today.
Peratryn	wysłany: 12 lat temu Right now the ID of these bosses is the NPC id associated with them. This doesn't work for all bosses. Some have a different ID in normal/heroic difficulties (the root of the whole Garalon issue) and some have multiple NPC's (as is the case in the ones that are currently wrong). Would you like it if the ID was put back to the npc id that it was previously, or would it be better to switch and display the encounter ID or some other unique ID to each boss encounter? The issue with doing that is that all of the ID's would switch. My current thinking is to deprecate the ID column here and put in an "encounterId" column that people should switch to using in the future.